Skip to content

Modified order of opentelemetry dependencies to avoid build failures#43023

Merged
rads-1996 merged 3 commits intoAzure:mainfrom
rads-1996:modify-ordering
Sep 16, 2025
Merged

Modified order of opentelemetry dependencies to avoid build failures#43023
rads-1996 merged 3 commits intoAzure:mainfrom
rads-1996:modify-ordering

Conversation

@rads-1996
Copy link
Copy Markdown
Member

@rads-1996 rads-1996 commented Sep 16, 2025

Description

Modified ordering of dependencies in setup.py to avoid dependency conflicts in future.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings September 16, 2025 16:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the dependency ordering in setup.py for the azure-monitor-opentelemetry package to prevent build failures and dependency conflicts. The change moves the opentelemetry-sdk~=1.36 dependency earlier in the list to ensure proper dependency resolution during package installation.

Key Changes

  • Reordered opentelemetry-sdk~=1.36 dependency to appear before other OpenTelemetry instrumentation packages
  • Updated CHANGELOG.md to document the dependency ordering change

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/monitor/azure-monitor-opentelemetry/setup.py Moved opentelemetry-sdk dependency to line 86, before other instrumentation packages
sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md Added changelog entry documenting the dependency ordering fix

@github-actions github-actions Bot added the Monitor - Distro Monitor OpenTelemetry Distro label Sep 16, 2025
@rads-1996 rads-1996 merged commit 1329ed1 into Azure:main Sep 16, 2025
19 checks passed
@rads-1996 rads-1996 deleted the modify-ordering branch September 16, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Monitor - Distro Monitor OpenTelemetry Distro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants